[U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern in C file

Fabio Estevam fabio.estevam at freescale.com
Fri Sep 2 16:02:18 CEST 2011


Avoid the usage of extern in C file as pointed out by checkpatch.

Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
---
Changes since v2:
- Place the extern in the MX25 imx-regs.h instead of inside the MX27 imx-regs.h
Changes since v1:
- No changes
 arch/arm/include/asm/arch-mx25/imx-regs.h |    1 +
 board/karo/tx25/tx25.c                    |    1 -
 2 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/include/asm/arch-mx25/imx-regs.h b/arch/arm/include/asm/arch-mx25/imx-regs.h
index 9e30f7c..7e34050 100644
--- a/arch/arm/include/asm/arch-mx25/imx-regs.h
+++ b/arch/arm/include/asm/arch-mx25/imx-regs.h
@@ -37,6 +37,7 @@
 #ifdef CONFIG_FEC_MXC
 extern void mx25_fec_init_pins(void);
 extern void imx_get_mac_from_fuse(unsigned char *mac);
+extern void mx25_uart1_init_pins(void);
 #endif
 
 /* Clock Control Module (CCM) registers */
diff --git a/board/karo/tx25/tx25.c b/board/karo/tx25/tx25.c
index 25b99e8..2787715 100644
--- a/board/karo/tx25/tx25.c
+++ b/board/karo/tx25/tx25.c
@@ -141,7 +141,6 @@ void tx25_fec_init(void)
 int board_init()
 {
 #ifdef CONFIG_MXC_UART
-	extern void mx25_uart1_init_pins(void);
 
 	mx25_uart1_init_pins();
 #endif
-- 
1.7.1




More information about the U-Boot mailing list