[U-Boot] [PATCH 2/2] powerpc/85xx: standardize display of address map size (32-bit vs. 36-bit)
Kumar Gala
galak at kernel.crashing.org
Fri Sep 2 20:24:10 CEST 2011
On Sep 2, 2011, at 8:41 AM, Timur Tabi wrote:
> Kumar Gala wrote:
>> Both. I'm think for your patch we'd add some general config option for extra print info.
>
> So you want to see this instead:
>
> /*
> * Display whether this is a 32-bit build or a 36-bit build.
> */
> #ifdef CONFIG_DISPLAY_ADDR_SIZE
> #ifdef CONFIG_PHYS_64BIT
> puts("ADDR: 36-bit address map\n");
> #else
> puts("ADDR: 32-bit address map\n");
> #endif
> #endif
>
> I still like my way better. It eliminates the need to think about another
> CONFIG option. I think adding another CONFIG option is worse than adding
> another line of text.
I think we could introduce kernel style "printk" levels that would allow more control over something like this.
- k
More information about the U-Boot
mailing list