[U-Boot] [PATCH] omap3evm: Set environment variable 'ethaddr'
Wolfgang Denk
wd at denx.de
Sat Sep 3 00:07:07 CEST 2011
Dear "Premi, Sanjeev",
In message <B85A65D85D7EB246BE421B3FB0FBB5930257371E07 at dbde02.ent.ti.com> you wrote:
>
> > Your patch always and unconditionally overwrites any existing
> > "ethaddr" settings. This is not acceptable.
>
> For the EVM, MAC address is always probed from the chip. Hence, I
> assumed it safe to set the ethaddr - without checking for env var.
This is not what we do in U-Boot, so please fix that.
> It was unlikely that someone would be setting it - to different
> value.
Unlikely? Not so. This is expected standard behaviour. Please don't
try to invent a wheel (in a different shape).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Save energy: Drive a smaller shell.
More information about the U-Boot
mailing list