[U-Boot] [PATCH] omap3: beagle: Fix build warning

[Premi, Sanjeev]

> -----Original Message-----
> From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net] 
> Sent: Monday, September 05, 2011 5:06 PM
> To: Premi, Sanjeev
> Cc: u-boot at lists.denx.de; Heiko Schocher; Wolfgang Denk
> Subject: Re: [U-Boot] [PATCH] omap3: beagle: Fix build warning
> 
> Hi Sanjeev,
> 
> Le 05/09/2011 12:25, Sanjeev Premi a écrit :
> > This patch fixes the warning dure to recent changes to the board
> > configuration:
> > cmd_i2c.o cmd_i2c.c -c
> > cmd_i2c.c:109:1: warning: missing braces around initializer
> > cmd_i2c.c:109:1: warning: (near initialization for 
> 'i2c_no_probes[0]')
> >
> > Signed-off-by: Sanjeev Premi<premi at ti.com>
> > Cc: Jason Kridner<jkridner at beagleboard.org>
> > ---
> >
> >   Patch was compile tested against the latest u-boot-arm.git at:
> >   58c583b : net: Check network device driver name
> >
> >   include/configs/omap3_beagle.h |    2 +-
> >   1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/configs/omap3_beagle.h 
> b/include/configs/omap3_beagle.h
> > index 18c6deb..a891246 100644
> > --- a/include/configs/omap3_beagle.h
> > +++ b/include/configs/omap3_beagle.h
> > @@ -118,7 +118,7 @@
> >   #define CONFIG_I2C_MULTI_BUS		1
> >
> >   /* Probe all devices */
> > -#define CONFIG_SYS_I2C_NOPROBES		{0x0, 0x0}
> > +#define CONFIG_SYS_I2C_NOPROBES		{{0x0, 0x0}}
> >
> >   /* USB */
> >   #define CONFIG_MUSB_UDC			1
> 
> Won't all board configs which use CONFIG_SYS_I2C_NOPROBES suffer from 
> the same bug? I would hate to see an endless trickle of 
> individual board 
> config patches, and would much prefer a single patch to fix 
> all boards 

[sp] Actually, not all boards suffer from this issue.
     But yes, I can make a single patch and submit it
     in next couple of hours.

> in one go if you are willing to do it -- yes, it would touch 
> boards that 
> you cannot even test, but I'd say the risk is next to zero.
> 
> Wolfgang, Heiko, your opinion?
> 
> Amicalement,
> -- 
> Albert.
>