[U-Boot] [PATCH] i2c_no_probes: Fix initialization warnings

[Premi, Sanjeev]

> -----Original Message-----
> From: Heiko Schocher [mailto:hs at denx.de] 
> Sent: Monday, September 05, 2011 7:13 PM
> To: Premi, Sanjeev
> Cc: u-boot at lists.denx.de; Albert ARIBAUD
> Subject: Re: [U-Boot] [PATCH] i2c_no_probes: Fix 
> initialization warnings
> 
> Hello Sanjeev,

[snip]...[snip]

> >   Compile tested for oma3_beagle only.
> 
> Compiling for example for the alpr board with your patch:
> 
> [hs at pollux u-boot]$ ./MAKEALL alpr
> Configuring for alpr board...
> cmd_i2c.c:115: warning: braces around scalar initializer
> cmd_i2c.c:115: warning: (near initialization for 'i2c_no_probes[0]')
> fpga.c:226: warning: initialization from incompatible pointer type
>    text    data     bss     dec     hex filename
>  231746   18612   68328  318686   4dcde ./u-boot
> 
> --------------------- SUMMARY ----------------------------
> Boards compiled: 1
> Boards with warnings or errors: 1 ( alpr )
> ----------------------------------------------------------
> [hs at pollux u-boot]$
> 
> -> so Sorry, NACK for this patch.

[sp] Didn't look at this reponse while I was responding to your
     earlier mail.

     One difference, I see notice between the warnings I got
     while building for beagle and the one you see:

     (beagle)
     cmd_i2c.c:109:1: warning: missing braces around initializer

     (alpr)
     cmd_i2c.c:115: warning: braces around scalar initializer

     The difference seems to be length of the array.

     (beagle)
     #define CONFIG_SYS_I2C_NOPROBES  {{0x0, 0x0}}

     (alpr)
     #define CONFIG_SYS_I2C_NOPROBES {{0x69}}

     So, temporarily, I changed the definition for beagle as
     #define CONFIG_SYS_I2C_NOPROBES  {{0x0}}

     ...but it succeeded.

     I am using "Codesourcery 2011.03-41". I will try using
     an older toolchain as well. Only trying to find of the
     original patch itself was right OR not.

~sanjeev

> 
> bye,
> Heiko
> -- 
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>