[U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern in C file

Marek Vasut marek.vasut at gmail.com
Mon Sep 5 18:12:35 CEST 2011


On Monday, September 05, 2011 06:02:21 PM Wolfgang Denk wrote:
> Dear Fabio Estevam,
> 
> In message 
<CAOMZO5A1v5jUkXTF9nKnZh8VNewzkoMB1tMmE9cRJCJDp+y2ug at mail.gmail.com> you wrote:
> > > But you're using extern in _header_ (.h) file ... so ... why ?
> > 
> > My patch removes the extern from the C file and put it on a header
> > file with other extern's.
> 
> What Marek probably wants to tell yet (in a bit a complicated way) is
> that you should omit the "extern" in the prototype declaration. Just
> remove all "extern" from the header file.

No, I was asking if there's some special reason for this or it's plain wrong. I 
see the later's the case.

Thanks, cheers!
> 
> Best regards,
> 
> Wolfgang Denk


More information about the U-Boot mailing list