[U-Boot] [PATCH v5 3/3] MX25: Add initial support for MX25PDK

[Stefano Babic]

On 09/05/2011 08:02 PM, Fabio Estevam wrote:
> Add the initial support for MX25PDK booting from SD card via internal boot.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> ---

Hi Fabio,

> diff --git a/board/freescale/mx25pdk/mx25pdk.c b/board/freescale/mx25pdk/mx25pdk.c
> new file mode 100644
> index 0000000..bb27824
> --- /dev/null
> +++ b/board/freescale/mx25pdk/mx25pdk.c
> @@ -0,0 +1,62 @@
> +/*
> + * (C) Copyright 2011 Freescale Semiconductor, Inc.
> + *
> + * Author: Fabio Estevam <fabio.estevam at freescale.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <common.h>
> +#include <asm/io.h>
> +#include <asm/arch/imx-regs.h>
> +#include <asm/arch/imx25-pinmux.h>
> +

But now you have to include sys_proto.h, right ? Else we have warnigs...

Moving imx_get_mac_from_fuse into sys_proto.h has a drawback. It
generates warning compiling the fec driver:

Configuring for tx25 board...
fec_mxc.c: In function 'fec_get_hwaddr':
fec_mxc.c:315: warning: implicit declaration of function
'imx_get_mac_from_fuse'

Because not all i.MX all processors have a sys_proto.h, this makes some
more cleanup as thought, and it is outside the scope of your patch. I
suggest you move only mx25_uart1_init_pins in sys_proto.h, and only fix
the warnings appearing with the i.MX25 boards.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================