[U-Boot] [PATCH] common: fix behavior of ROUND macro when input is already rounded

Wolfgang Denk wd at denx.de
Wed Sep 7 23:39:45 CEST 2011


Dear Anton Staaf,

In message <1315007128-10710-1-git-send-email-robotboy at chromium.org> you wrote:
> Currently when you call ROUND with a value that is already a
> multiple of the second parameter it will return a value that is
> one multiple larger, instead of returning the value passed in.
> 
> There are only two types of usage of ROUND currently, one in
> various config files to round CONFIG_SYS_MALLOC_LEN to a multiple
> of 4096 bytes.  The other in cmd_sf.c where the incorrect behavior
> of ROUND is worked around be subtracting one from the length argument
> before passing it to ROUND.
> 
> This patch fixes ROUND and removes the workaround from cmd_sf.  It
> also results in all of the malloc pools that use ROUND to compute
> their size shrinking by 4KB.
> 
> Cc: Lukasz Majewski <l.majewski at samsung.com>
> Cc: Mike Frysinger <vapier at gentoo.org>
> ---
> 
> I'm not sure if it makes sense to go and add 4KB to each malloc pool effected.  What do other people think?  I'd be happy to make a v2 that does that.  This just seemed like a cleaner v1 to start with.
> 
>  common/cmd_sf.c  |    2 +-
>  include/common.h |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There are three principal ways to lose money: wine, women, and engi-
neers. While the first two are more pleasant, the third is by far the
more certain."                           - Baron Rothschild, ca. 1800


More information about the U-Boot mailing list