[U-Boot] [PATCH v5 1/3] net: Adds Fast Ethernet Controller driver for Armada100

[Prafulla Wadaskar]

> -----Original Message-----
> From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
> Sent: Friday, September 02, 2011 10:49 AM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; vapier at gentoo.org; marek.vasut at gmail.com; Ajay
> Bhargav
> Subject: [PATCH v5 1/3] net: Adds Fast Ethernet Controller driver for
> Armada100
> 
> This patch adds support for Fast Ethernet Controller driver for
> Armada100 series.
> 
> Signed-off-by: Ajay Bhargav <ajay.bhargav at einfochips.com>
> ---
> Changes for v2:
> 	- removed random MAC generation
> 	- driver init function changed to register as per new naming
> convention
> 	- code cleanup (Thanks to Wolfgang, Marek & Mike for tips)
> Changes for v3:
> 	- code cleanup
> Changes for v4:
> 	- Debug and Error messages updated
> 	- base_addr param for armada100_fec_register changed to unsigned
> long
> Changes for v5:
> 	- Coding style cleanup
> 	- removed unwanted function
> 
>  arch/arm/include/asm/arch-armada100/armada100.h |    1 +
>  drivers/net/Makefile                            |    1 +
>  drivers/net/armada100_fec.c                     |  736
> +++++++++++++++++++++++
>  drivers/net/armada100_fec.h                     |  232 +++++++
>  include/netdev.h                                |    1 +
>  5 files changed, 971 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/net/armada100_fec.c
>  create mode 100644 drivers/net/armada100_fec.h
> 
> diff --git a/arch/arm/include/asm/arch-armada100/armada100.h
> b/arch/arm/include/asm/arch-armada100/armada100.h
> index d5d125a..3d567eb 100644
> --- a/arch/arm/include/asm/arch-armada100/armada100.h
> +++ b/arch/arm/include/asm/arch-armada100/armada100.h
> @@ -59,6 +59,7 @@
>  #define ARMD1_MPMU_BASE		0xD4050000
>  #define ARMD1_APMU_BASE		0xD4282800
>  #define ARMD1_CPU_BASE		0xD4282C00
> +#define ARMD1_FEC_BASE		0xC0800000

This is not in order should be above 0xDxxx

Otherwise Ack for rest of the code.

Regards..
Prafulla . .