[U-Boot] [PATCH 1/2] net/eth.c: throw BUG for eth_get_dev_by_name(NULL)

Wolfgang Denk wd at denx.de
Thu Sep 8 13:08:38 CEST 2011


Dear Helmut Raiger,

In message <1314008237-24180-1-git-send-email-helmut.raiger at hale.at> you wrote:
> eth_get_dev_by_name() is not safe to use for devname being NULL
> as it uses strcmp. This patch makes it fail with a BUG().
> 
> Signed-off-by: Helmut Raiger <helmut.raiger at hale.at>
> ---
> V2: use BUG_ON() instead of gracefully returning 0
> 
>  net/eth.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"...all the  good  computer  designs  are  bootlegged;  the  formally
planned  products,  if  they  are built at all, are dogs!" - David E.
Lundstrom, "A Few Good Men From Univac", MIT Press, 1987


More information about the U-Boot mailing list