[U-Boot] [PATCH] arm: RFC: add clock speed constants

[Simon Glass]

Hi Wolfgang,

On Thu, Sep 8, 2011 at 3:34 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Simon Glass,
>
> In message <1315520711-9667-1-git-send-email-sjg at chromium.org> you wrote:
>> Large-value clock speeds are error-prone, so we add a new file which defines
>> these in a standard manner across ARM U-Boot code.
>>
>> Any interest in having something like this in include/clocks.h?
>
> Sorry, but I dislike defines like thess because they actually
> obfuscate the code.

Oh, ok.

>
>> + * Please order the items by increasing Hz
>> + */
>> +enum {
>> +     CLK_32768       = 32768,
>> +     CLK_20M         = 20000000,
>> +     CLK_24M         = 24000000,
>> +     CLK_144M        = 144000000,
>> +     CLK_216M        = 216000000,
>> +     CLK_300M        = 300000000,
>> +};
>
> NAK. I don't want to see anything like that.  [And I would welcome
> patches to get rid of this SZ_* mess.]

[Do you mean arch/arm/include/asm/sizes.h?]

Regards,
Simon

>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Backed up the system lately?
>