[U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl

[Stefano Babic]

On 09/09/2011 09:36 AM, Wolfgang Denk wrote:
> Dear Stefano Babic,
> 
> In message <1315552622-27566-1-git-send-email-sbabic at denx.de> you wrote:
>> get_ram_size() is called, but memsize.c is not compiled.
>>
>> Signed-off-by: Stefano Babic <sbabic at denx.de>
>> ---
>>  nand_spl/board/davinci/da8xxevm/Makefile |    6 +++++-
>>  1 files changed, 5 insertions(+), 1 deletions(-)
>>
>> diff --git a/nand_spl/board/davinci/da8xxevm/Makefile b/nand_spl/board/davinci/da8xxevm/Makefile
>> index b3f4bd6..65ed055 100644
>> --- a/nand_spl/board/davinci/da8xxevm/Makefile
>> +++ b/nand_spl/board/davinci/da8xxevm/Makefile
>> @@ -38,7 +38,7 @@ CFLAGS	+= -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL
>>  
>>  SOBJS	= start.o _udivsi3.o _divsi3.o
>>  COBJS	= cpu.o davinci_nand.o ns16550.o div0.o davinci_pinmux.o psc.o	\
>> -	misc.o hawkboard_nand_spl.o nand_boot.o
>> +	misc.o hawkboard_nand_spl.o nand_boot.o memsize.o
> 
> Please split these litst (one object name per line), and sort them.

Ok.

> 
>> +# from comon directory
>> +$(obj)memsize.c:
>> +	@rm -f $@
>> +	ln -s $(TOPDIR)/common/memsize.c $@
> 
> Can we not rather compile the file in the common directory instead?

This is only for nand_spl, not for u-boot. The nand_spl/board/Makefile
has the list of files that must be compiled. Of course, the file was
already compiled in common for u-boot.bin.

Not sure why this issue appears now. Rebuilding all ARM boards I see
that hawkboard is broken, I have not bisect to check when it happened.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================