[U-Boot] [PATCH 18/31] iMX28: Add SPI driver

Stefano Babic sbabic at denx.de
Fri Sep 9 14:34:05 CEST 2011


On 09/09/2011 01:50 PM, Marek Vasut wrote:

>>
>> Only the CS supplied in the SOC are supported, it is not possible to use
>> a GPIO. Please add a comment to explain that.

If you see other SPI drivers (mxc_spi.c, or blackfin, and other, too)
the CS is or can be implemented with a gpio. Some architecture have a
board specific spi_cs_activate.

In your driver, only the CS of the SPI controller are supported. My only
remark is if we can add a comment to explain this.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================


More information about the U-Boot mailing list