[U-Boot] [PATCH 0/7] Bootgraph.pl instrumentation support for UBoot

Simon Glass sjg at chromium.org
Tue Sep 13 14:22:38 CEST 2011


Hi Graeme,

On Tue, Sep 13, 2011 at 5:01 AM, Graeme Russ <graeme.russ at gmail.com> wrote:
> Hi Simon,
>
> On 13/09/11 21:52, Simon Glass wrote:
>> Hi Graeme,
>>
>> On Mon, Sep 12, 2011 at 10:24 PM, Graeme Russ <graeme.russ at gmail.com> wrote:
>>> Hi Simon,
>>>
>>> On Tue, Sep 13, 2011 at 2:34 PM, Simon Glass <sjg at chromium.org> wrote:
>>>> Hi Andrew,
>>>>
>>>> On Sat, Sep 10, 2011 at 5:40 AM, Andrew Murray <amurray at theiet.org> wrote:
>>>>> On 1 September 2011 00:53, Andrew Murray <amurray at theiet.org> wrote:
>>>>>>
>
> [snip]
>
>>>  - Bootgraph
>>>  - Unified timer API (nanosecond would be nice)
>>>  - initcall
>>>  - 'pre-console' output buffer
>>>  - timestamped printf()
>>>
>>> Looking forward to opening up these cans of worms again :)
>>
>> Bravery is to be encouraged. Biting off what seems like the smallest,
>> what is the status of pre-console output?
>
> I made the requested changes, the pre-console buffer only gets compiled in
> if it is explicitly configured and it works a treat
>
> I see no reason not to include it (along with the pre-console printf()
> squelching)

I agree, it has my vote. I will test it again this week and come back to you.

>
> The only related patch that was under discussion was 'flagifying' a couple
> of global variables which opened up a question regarding the impact on API
> versioning - Wolfgang resolved this with 'gd does not impact API version'
> so the 'flagify' patch could also be added to the mix, but that's not
> really that critical and could come in later after the dust settles.

OK yes, I remember, a separate patch then.

>
> Unified timer API would be the next 'least contentious' - There is
> universal agreement on the why, but not on the how. I'll reopen this again
> 'soon'

Good, and good luck

>
> The initcall API is the most contentious... Asbestos suit is still on the
> clothes line drying ;)

I'm impressed that you didn't wear that out with the timer stuff. You
must have bought a really high quality suit!

Regards,
Simon

>
> Regards,
>
> Graeme
>


More information about the U-Boot mailing list