[U-Boot] [PATCH 2/9] powerpc/mpc85xxcds: Fix PCI speed

Scott Wood scottwood at freescale.com
Tue Sep 13 22:02:02 CEST 2011


On 09/13/2011 02:20 PM, Tabi Timur-B04825 wrote:
> On Tue, Sep 13, 2011 at 2:15 AM, Zhao Chenhui
> <chenhui.zhao at freescale.com> wrote:
> 
>> @@ -222,8 +222,8 @@ int checkboard (void)
>>
>>        printf("PCI1: %d bit, %s MHz, %s\n",
>>                (pci1_32) ? 32 : 64,
>> -               (pci1_speed == 33000000) ? "33" :
>> -               (pci1_speed == 66000000) ? "66" : "unknown",
>> +               (pci1_speed == 33333333) ? "33" :
>> +               (pci1_speed == 66666666) ? "66" : "unknown",
> 
> I already told you on the internal mailing list to fix this, because
> it can never say "unknown".  pci1_speed will always equal either
> 33333333 or 66666666.  There is no way it can be set to anything else.

There's no way it can be 33333000, 66000000, etc. based on the board's
crystal?

Not that "unknown" is the right response to those values, of course.

-Scott



More information about the U-Boot mailing list