[U-Boot] [PATCH] powerpc/p3060: Add SoC related support for P3060 platform

[Kumar Gala]

On Sep 15, 2011, at 9:43 AM, John Schmoller wrote:

> Hello Kumar,
> 
>> From: Shengzhou Liu <Shengzhou.Liu at freescale.com>
>> 
>> Add P3060 SoC specific information:cores setup, LIODN setup, etc
>> 
>> The P3060 SoC combines six e500mc Power Architecture processor cores
>> with
>> high-performance datapath acceleration architecture(DPAA), CoreNet
>> fabric
>> infrastructure, as well as network and peripheral interfaces.
>> 
>> Signed-off-by: Shengzhou Liu <Shengzhou.Liu at freescale.com>
>> Signed-off-by: Kumar Gala <galak at kernel.crashing.org>
>> ---
> 
> <SNIP>
> 
>> +#elif defined(CONFIG_PPC_P3060)
>> +#define CONFIG_MAX_CPUS			8
> 
> I admit that I don't know anything about the P3060, but from your commit log above and Freescale standard naming conventions, shouldn't CONFIG_MAX_CPUS be 6?
> 
> Thanks,
> John

I was wondering if this was going to be noticed.  I need to add a comment.  The MAX_CPUS is the max(ID+1,# of cores).  On P3060 the cores are # 0,1, 4, 5, 6, 7.

- k