[U-Boot] [PATCH 1/3] image: add support for Android's boot image format

Sebastian Andrzej Siewior bigeasy at linutronix.de
Fri Sep 16 21:08:28 CEST 2011


On 09/16/2011 08:22 PM, Mike Frysinger wrote:
> On Friday, September 16, 2011 12:51:17 Sebastian Andrzej Siewior wrote:
>> +#ifdef CONFIG_ANDROID_BOOT_IMAGE
>
> we already have a standard here: CONFIG_BOOTM_ANDROID

Ehm. Can't follow. If you want me to s/CONFIG_ANDROID_BOOT_IMAGE
/CONFIG_BOOTM_ANDROID/ I sure can do this. The uImage has no CONFIG
around it and the other format has CONFIG_FIT around it.
A grep for CONFIG_BOOTM_ returns LINUX, NETBSD and others. They differ
in the calling ABI, argument passing etc. I do boot here a Linux image
but not from an uImage.

>> +static u32 andoir_img_get_kload(struct andr_img_hdr *hdr)
>
> looks like you missed a "d" in that "andoir"

yup, fixing, thanks.

> -mike

Sebastian


More information about the U-Boot mailing list