[U-Boot] [RFC PATCH 13/20] sandbox: Add OS dependent layer

[Mike Frysinger]

On Saturday, September 17, 2011 12:48:52 Simon Glass wrote:
> --- a/arch/sandbox/config.mk
> +++ b/arch/sandbox/config.mk
>
> -PLATFORM_CPPFLAGS += -DCONFIG_SANDBOX -D__SANDBOX__
> +PLATFORM_CPPFLAGS += -DCONFIG_SANDBOX -D__SANDBOX__ -I/usr/include

since this gets used by all u-boot files, shouldnt the /usr/include path get 
added only for specific files/dirs ?  the ones that glue the u-boot world to 
the host C library ?

> --- /dev/null
> +++ b/board/sandbox/common/Makefile
>
> +clean:
> +	rm -f $(SOBJS) $(OBJS)
> +
> +distclean:	clean
> +	rm -f $(LIB) core *.bak $(obj).depend

these dont get used, so punt them

> --- /dev/null
> +++ b/board/sandbox/common/os.c

isnt this an "arch" issue and not "board" ?

> --- /dev/null
> +++ b/include/os.h

seems like this glue should be in the sandbox arch subdir
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110917/b8cd60e2/attachment.pgp