[U-Boot] [RFC PATCH 02/20] sandbox: Add architecture image support

Simon Glass sjg at chromium.org
Sun Sep 18 05:57:12 CEST 2011


On Sat, Sep 17, 2011 at 12:29 PM, Marek Vasut <marek.vasut at gmail.com> wrote:
> On Saturday, September 17, 2011 06:48:41 PM Simon Glass wrote:
>> We won't actually load an image with this architecture, but we still need
>> to define it.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>  common/image.c  |    5 +++--
>>  include/image.h |    3 +++
>>  2 files changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/common/image.c b/common/image.c
>> index d38ce4a..8283561 100644
>> --- a/common/image.c
>> +++ b/common/image.c
>> @@ -1581,7 +1581,7 @@ int boot_get_fdt (int flag, int argc, char * const
>> argv[], bootm_headers_t *imag goto error;
>>               }
>>
>> -             printf ("   Booting using the fdt blob at 0x%x\n",
> (int)fdt_blob);
>> +             printf("   Booting using the fdt blob at 0x%p\n", fdt_blob);
>
> Well this is a fix and the patch description doesn't match it.
>
> Can you split it or something?

Yes ok, there are a couple like this. When this becomes real patch I
will separate them out. This one should be split so that image.c and
image.h are separate patches.

Regards,
Simon

>
> Cheers
>


More information about the U-Boot mailing list