[U-Boot] [PATCH] Add support for IDS8313 boards
Wolfgang Denk
wd at denx.de
Tue Sep 20 09:36:05 CEST 2011
Dear Sergej,
In message <4206182445660643B9AEB8D4E55BBD0A15399E41F3 at HERMES2> you wrote:
>
> i have 2 questions:
> 1. which version of checkpatch has to be used?
> I used the one from 2.6.37 kernel.
We normally use the one from the latest kernel version (v3.1-rc6),
i. e. version 0.32
> 2. after the clean i got 6 warnings like
> ...
> WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
> ...
> total: 0 errors, 6 warnings, 804 lines checked
>
> Is it acceptable in u-boot software?
No, we insist on proper use of I/O accesssors as well. There are a
few areas where it cannot be avoided (because existing functions use
such types as parameters), but there shoul be no need for any new
volatiles.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Uncertain fortune is thoroughly mastered by the equity of the calcu-
lation. - Blaise Pascal
More information about the U-Boot
mailing list