[U-Boot] [RFC PATCH 17/20] sandbox: Add basic config file

[Simon Glass]

Hi Mike,

On Sat, Sep 17, 2011 at 5:22 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Saturday, September 17, 2011 12:48:56 Simon Glass wrote:
>> --- /dev/null
>> +++ b/include/configs/sandbox.h
>
> missing #ifdef multiple include protection
>
>> +#define CONFIG_NR_DRAM_BANKS 1
>> +#define CONFIG_SYS_SDRAM_BASE        0

I don't need this ^^

>> +#define CONFIG_DRAM_SIZE     (128 << 20)
>
> do you need any of this ?

I want to have simulated DRAM, so yes. But I will make it start always
at 0 which removes one item.

>
>> +#define      CONFIG_SYS_PROMPT               "=>"    /* Command Prompt */
>
> this file has a bunch of "#define<tab>" where it should be "#define<space>"

OK, fixed.

>
>> +#define CONFIG_LMB
>
> i dont think you need this either ?

No, removed.

Regards,
Simon

> -mike
>