[U-Boot] [PATCH 1/2] GCC4.6: Convert various empty macros to inline functions

Mike Frysinger vapier at gentoo.org
Sat Sep 24 07:05:38 CEST 2011


On Friday, September 23, 2011 20:40:25 Marek Vasut wrote:
> On Saturday, September 24, 2011 01:04:51 AM Mike Frysinger wrote:
> > On Friday, September 23, 2011 17:52:35 Marek Vasut wrote:
> > > > On Friday, September 23, 2011 15:09:52 Marek Vasut wrote:
> > > > > --- a/include/common.h
> > > > > +++ b/include/common.h
> > > > > 
> > > > > -#define debugX(level,fmt,args...)
> > > > > +static inline void debugX(const char *fmt, ...) {}
> > > > 
> > > > NAK:   you broke debugX()
> > > 
> > > oh, right, good catch. But is this macro even used anyway?
> > 
> > grep says yes, a little
> 
> Maybe we should just squash it and get rid of it altogether ?

i've rarely found a need for this sort of style of debug logging, so i 
wouldn't mind seeing it go
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110924/ed6f5ad5/attachment.pgp 


More information about the U-Boot mailing list