[U-Boot] [PATCH] USB: Add usb_event_poll() to get keyboards working with EHCI

Remy Bohmer linux at bohmer.net
Sat Sep 24 18:56:23 CEST 2011


Hi,

2011/9/24 Marek Vasut <marek.vasut at gmail.com>:
> On Saturday, September 24, 2011 06:41:58 PM Remy Bohmer wrote:
>> Hi,
>>
>> 2011/9/23 Marek Vasut <marek.vasut at gmail.com>:
>> > Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
>> > Cc: Remy Bohmer <linux at bohmer.net>
>> > ---
>> >  drivers/usb/host/ehci-hcd.c |   33 ++++++++++++++++++++++++++++++++-
>> >  1 files changed, 32 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
>> > index 52b98c2..5b53b3a 100644
>> > --- a/drivers/usb/host/ehci-hcd.c
>> > +++ b/drivers/usb/host/ehci-hcd.c
>> > @@ -27,6 +27,10 @@
>> >  #include <malloc.h>
>> >  #include <watchdog.h>
>> >  #include <usb/ehci-fsl.h>
>> > +#ifdef CONFIG_USB_KEYBOARD
>> > +#include <stdio_dev.h>
>> > +extern unsigned char new[];
>> > +#endif
>> >
>> >  #include "ehci.h"
>> >
>> > @@ -914,5 +918,32 @@ submit_int_msg(struct usb_device *dev, unsigned long
>> > pipe, void *buffer,
>> >
>> >        debug("dev=%p, pipe=%lu, buffer=%p, length=%d, interval=%d",
>> >              dev, pipe, buffer, length, interval);
>> > -       return -1;
>> > +       return ehci_submit_async(dev, pipe, buffer, length, NULL);
>>
>> Why is changing this line needed?
>
> To actually submit the interrupt request ?

Was just checking... at first impression it appeared to be some
unrelated change. While looking at it in its context it seems indeed
logical.

> Ah right ... there must be some changes in my repo or u-boot-imx/next ... will
> do in my next submission round.

OK. I will pull it in then.

Kind regards,

Remy


More information about the U-Boot mailing list