[U-Boot] [PATCH] image: push default arch values to arch headers
Wolfgang Denk
wd at denx.de
Mon Sep 26 08:08:51 CEST 2011
Dear Mike Frysinger,
In message <1317016410-608-1-git-send-email-vapier at gentoo.org> you wrote:
> This pushes the ugly duplicated arch ifdef lists we maintain in various
> image related files out to the arch headers themselves.
I appreciate this change in general, but ...
...
> -#else
> -# error Unknown CPU type
> -#endif
> - return 0;
> -
> - return 1;
> + return !fit_image_check_arch(fdt, node, IH_ARCH_DEFAULT));
...here you change a compile time error check into a runtim error.
Please fix this.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Ahead warp factor 1" - Captain Kirk
More information about the U-Boot
mailing list