[U-Boot] [PATCH 4/4 V5] I2C: mxc_i2c rework

Heiko Schocher hs at denx.de
Mon Sep 26 08:30:32 CEST 2011


Hello Stefano,

Stefano Babic wrote:
> On 09/23/2011 05:32 AM, Jason Hui wrote:
>> Hi, Marek,
>>
>> On Fri, Sep 23, 2011 at 3:22 AM, Marek Vasut <marek.vasut at gmail.com> wrote:
>>> Rewrite the mxc_i2c driver.
>>>  * This version is much closer to Linux implementation.
>>>  * Fixes IPG_PERCLK being incorrectly used as clock source
>>>  * Fixes behaviour of the driver on iMX51
>>>  * Clean up coding style a bit ;-)
>>>
>>> Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
>>> Cc: Stefano Babic <sbabic at denx.de>
>>> Cc: Heiko Schocher <hs at denx.de>
>>> Cc: Jason Hui <jason.hui at linaro.org>
>>> ---
>>>  drivers/i2c/mxc_i2c.c |  422 +++++++++++++++++++++++++++++++++----------------
>>>  1 files changed, 289 insertions(+), 133 deletions(-)
>>>
>>> V2: Use PERCLK as a source.
>>> V3: Remove forgotten unused variables.
>>> V4: Add missing Cc field to commit message.
>>> V5: Correct TX_NO_AK bit handling.
>>>
>> Test on i.MX53evk, it woks now.
>>
>> Acked-by: Jason Liu <jason.hui at linro.org>
>> Tested-by: Jason Liu <jason.hui at linro.org>
> 
> Thanks everybody for the good work !

Yep! Thanks to Marek and Jason.

> I will merge now this series into u-boot-imx. I do not see any open
> issus (please correct me if I am wrong !).

Acked-by: Heiko Schocher <hs at denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list