[U-Boot] [PATCH] GCC4.4: Squash multiple warnings due to strict aliasing

Nick Thompson nick.thompson at ge.com
Mon Sep 26 11:26:51 CEST 2011


On 26/09/11 03:06, Marek Vasut wrote:
> Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
> ---
>  arch/arm/include/asm/io.h |   30 ++++++++++++++++++------------
>  1 files changed, 18 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h
> index 1fbc531..61f4987 100644
> --- a/arch/arm/include/asm/io.h
> +++ b/arch/arm/include/asm/io.h
> @@ -78,43 +78,49 @@ static inline phys_addr_t virt_to_phys(void * vaddr)
>  extern inline void __raw_writesb(unsigned int addr, const void *data, int bytelen)
>  {
>  	uint8_t *buf = (uint8_t *)data;
> -	while(bytelen--)
> -		__arch_putb(*buf++, addr);
> +	int i;
> +	for (i = 0; i < bytelen; i++)
> +		__arch_putb(buf[i], addr);
>  }
>  

This fixes the problem in these use cases, but leaves the door open.

Would it be better to change the __arch_putb macro into an extern inline function
instead which would catch these and future cases?

Nick.


More information about the U-Boot mailing list