[U-Boot] [PATCH] net/eth: add newline to "failed MAC address" warning

Philip Balister philip at balister.org
Mon Sep 26 16:24:54 CEST 2011


On 09/23/2011 08:47 AM, Holger Brunck wrote:
> This prevents u-boot to display during bootime:
> Out:   serial
> Err:   serial
> Net:   UEC3Warning: failed to set MAC address
>
> Now corrected and it will display:
> Out:   serial
> Err:   serial
> Net:   UEC3
> Warning: failed to set MAC address
>
> Signed-off-by: Holger Brunck<holger.brunck at keymile.com>

Acked-by: Philip Balister <philip at opensdr.com>

But, when i submitted the same patch, I was told this is not the right 
way to solve the problem. I would still like to see this patch go in 
until someone has time to rewrite the problem section of code.

Philip

> ---
>   net/eth.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/eth.c b/net/eth.c
> index 02baa37..1c0c780 100644
> --- a/net/eth.c
> +++ b/net/eth.c
> @@ -302,7 +302,7 @@ int eth_initialize(bd_t *bis)
>   				puts("\nWarning: eth device name has a space!\n");
>
>   			if (eth_write_hwaddr(dev, "eth", eth_number))
> -				puts("Warning: failed to set MAC address\n");
> +				puts("\nWarning: failed to set MAC address\n");
>
>   			eth_number++;
>   			dev = dev->next;



More information about the U-Boot mailing list