[U-Boot] [PATCH] powerpc/85xx: corenet_ds: increase console buffer size to 1024

[Kim Phillips]

On Sun, 25 Sep 2011 22:11:34 +0200
Wolfgang Denk <wd at denx.de> wrote:

> Dear Kim Phillips,
> 
> In message <20110923140020.1eac241b.kim.phillips at freescale.com> you wrote:
> >
> > > Can you explain this in a bit more detail.
> > 
> > if, for whatever reason, the nfsboot env var has been
> > modified/deleted, one can't restore it via the command line
> > because it doesn't fit in the buffer.  Currently command-line typing
> > stops 2 chars short of its full definition, i.e,. at the 2nd 'd' in
> > 'fdtaddr':
> > 
> > => setenv nfsboot 'setenv bootargs root=/dev/nfs rw nfsroot=$serverip:$rootpath ip=$ipaddr:$serverip:$gatewayip:$netmask:$hostname:$netdev:off console=$consoledev,$baudrate $othbootargs;tftp $loadaddr $bootfile;tftp $fdtaddr $fdtfile;bootm $loadaddr - $
> > fdtadd
> 
> Instead of extending buffer sizes just to be able to enter some
> incomrephensible looooong variable setting you should try and figure

this variable (which I have been comprehending for years now), is
part of the default environment configuration for that board, and
many others - it's defined in the board config file.

> out how to structure environment settings, so they become easier to
> understand and to manage to the end user.

with the amount of boardfarm users we have (recall the 'my_boot' and
'my_dtb' env vars in the grepenv rationale?), it's unrealistic to
expect all to agree on how they want to set up and use their
environment.  

We need to enable reverting an env var to its original default
definition.

> The manual holds some pretty edicative examples.

Perhaps over time the nfsboot norm setting should be migrated to
something more modular in the board config files, but right now,
users are complaining about simply expecting to being able to type
two more characters on the command line.

Kim