[U-Boot] [PATCH] net/eth: add newline to "failed MAC address" warning

Holger Brunck holger.brunck at keymile.com
Mon Sep 26 18:40:17 CEST 2011


On 09/26/2011 06:07 PM, Mike Frysinger wrote:
> On Monday, September 26, 2011 10:24:54 Philip Balister wrote:
>> On 09/23/2011 08:47 AM, Holger Brunck wrote:
>>> This prevents u-boot to display during bootime:
>>> Out:   serial
>>> Err:   serial
>>> Net:   UEC3Warning: failed to set MAC address
>>>
>>> Now corrected and it will display:
>>> Out:   serial
>>> Err:   serial
>>> Net:   UEC3
>>> Warning: failed to set MAC address
>>>
>>> Signed-off-by: Holger Brunck<holger.brunck at keymile.com>
>>
>> Acked-by: Philip Balister <philip at opensdr.com>
>>
>> But, when i submitted the same patch, I was told this is not the right
>> way to solve the problem. I would still like to see this patch go in
>> until someone has time to rewrite the problem section of code.
> 
> i don't think it is the right way long term, but short term, i think it's 
> correct wrt the surrounding code.

Yes I agree. It never meant to be more than a bootlog improvement. The root
cause should be fixed in the long term.

Regards
Holger




More information about the U-Boot mailing list