[U-Boot] [PATCH 5/6] da850: add support to read mac address from spi flash

Mike Frysinger vapier at gentoo.org
Fri Sep 30 17:51:34 CEST 2011


On Friday, September 30, 2011 07:24:26 nagabhushana.netagunte at ti.com wrote:
> +		if (is_multicast_ether_addr(buff) ||
> +				is_zero_ether_addr(buff)) {

NAK: use is_valid_ether_addr()

> +		sprintf((char *)enetaddr, "%pM", buff);
> +
> +		eth_setenv_enetaddr("ethaddr", enetaddr);

NAK: eth_setenv_enetaddr() does the sprintf for you
-mike


More information about the U-Boot mailing list