[U-Boot] [PATCH v2 03/10] net: cosmetic: net.c checkpatch compliance

[Simon Glass]

Hi Joe,

On Tue, Mar 27, 2012 at 4:42 PM, Joe Hershberger <joe.hershberger at ni.com> wrote:
> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Joe Hershberger <joe.hershberger at gmail.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Mike Frysinger <vapier at gentoo.org>
> ---
> Changes for v2:
>   - Split into smaller patches
>
>  net/bootp.c |  340 ++++++++++++++++++++++++++++++-----------------------------
>  net/bootp.h |   56 +++++-----
>  2 files changed, 203 insertions(+), 193 deletions(-)
>
> diff --git a/net/bootp.c b/net/bootp.c
> index 35654b4..d0a7da2 100644
> --- a/net/bootp.c
> +++ b/net/bootp.c

> @@ -64,37 +64,29 @@ static char *dhcpmsg2str(int type)
>        }
>  }
>  #endif
> -
> -#if defined(CONFIG_BOOTP_VENDOREX)
> -extern u8 *dhcp_vendorex_prep (u8 *e); /*rtn new e after add own opts. */
> -extern u8 *dhcp_vendorex_proc (u8 *e); /*rtn next e if mine,else NULL  */
> -#endif
> -
>  #endif
>
>  static int BootpCheckPkt(uchar *pkt, unsigned dest, unsigned src, unsigned len)
>  {
> -       Bootp_t *bp = (Bootp_t *) pkt;
> +       struct Bootp_t *bp = (struct Bootp_t *) pkt;

I'm not sure of the ordering of the serieses, but if this one comes
first, then struct Bootp_t doesn't exist yet - it is only a typedef.

Regards,
Simon