[U-Boot] [PATCH v2] mvgbe: remove warning for unused methods

Prafulla Wadaskar prafulla at marvell.com
Mon Apr 2 14:44:59 CEST 2012


 

> -----Original Message-----
> From: Prafulla Wadaskar 
> Sent: 26 March 2012 15:54
> To: 'Valentin Longchamp'; u-boot at lists.denx.de
> Cc: Stefan Bigler; Gerlando Falauto; Holger Brunck
> Subject: RE: [PATCH v2] mvgbe: remove warning for unused methods
> 
> 
> 
> > -----Original Message-----
> > From: Valentin Longchamp [mailto:valentin.longchamp at keymile.com]
> > Sent: 26 March 2012 15:32
> > To: u-boot at lists.denx.de
> > Cc: Stefan Bigler; Valentin Longchamp; Gerlando Falauto; Prafulla 
> > Wadaskar; Holger Brunck
> > Subject: [PATCH v2] mvgbe: remove warning for unused methods
> > 
> > From: Stefan Bigler <stefan.bigler at keymile.com>
> > 
> > Some baords may use the GBE interface but they have no phy 
> connected 
> > to the interface and a direct MAC/MAC interface.
> > For them we need to get rid of compiler warnings.
> > 
> > Signed-off-by: Stefan Bigler <stefan.bigler at keymile.com>
> > Signed-off-by: Valentin Longchamp <valentin.longchamp at keymile.com>
> > cc: Gerlando Falauto <gerlando.falauto at keymile.com>
> > cc: Prafulla Wadaskar <prafulla at marvell.com>
> > cc: Holger Brunck <holger.brunck at keymile.com>
> > ---
> >  drivers/net/mvgbe.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c index 
> > 1dcb700..df258b9 100644
> > --- a/drivers/net/mvgbe.c
> > +++ b/drivers/net/mvgbe.c
> > @@ -52,6 +52,7 @@ DECLARE_GLOBAL_DATA_PTR;  #define 
> MV_PHY_ADR_REQUEST 
> > 0xee  #define MVGBE_SMI_REG (((struct mvgbe_registers 
> > *)MVGBE0_BASE)->smi)
> > 
> > +#if defined(CONFIG_MII) || defined(CONFIG_CMD_MII)
> >  /*
> >   * smi_reg_read - miiphy_read callback function.
> >   *
> > @@ -181,6 +182,7 @@ static int smi_reg_write(const char 
> *devname, u8 
> > phy_adr, u8 reg_ofs, u16 data)
> > 
> >  	return 0;
> >  }
> > +#endif
> > 
> >  /* Stop and checks all queues */
> >  static void stop_queue(u32 * qreg)
> > --
> > 1.7.1
> 
> Acked-by: Prafulla Wadaskar <Prafulla at marvell.com>

Hi Joe

May you please pull this patch in u-boot-net.git?

This does not have any further dependency, whereas it is a dependency for some other patchset

Regards..
Prafulla . . .


More information about the U-Boot mailing list