[U-Boot] [PATCH V2 2/4] ARM: 926ejs: use debug() for misaligned addresses

Marek Vasut marex at denx.de
Mon Apr 2 18:29:55 CEST 2012


Dear Stefano Babic,

> Misaligned warnings are useful to debug faulty drivers.
> A misaligned warning is printed also when the driver
> is correct - use debug() instead of printf().
> 
> Signed-off-by: Stefano Babic <sbabic at denx.de>
> CC: Albert Aribaud <albert.u.boot at aribaud.net>
> CC: Mike Frysinger <vapier at gentoo.org>
> CC: Marek Vasut <marex at denx.de>

Acked-by: Marek Vasut <marex at denx.de>

> ---
> 
> Changes since V1:
> 
> This substitutes [PATCH 2/4] net: round up before calling flush_cache
> - change warning in cache.c instead of fixing cmd_net.c
> 	(M. Frysinger, M. Vasut)
> 
>  arch/arm/cpu/arm926ejs/cache.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm926ejs/cache.c
> b/arch/arm/cpu/arm926ejs/cache.c index 5b23e3a..4430578 100644
> --- a/arch/arm/cpu/arm926ejs/cache.c
> +++ b/arch/arm/cpu/arm926ejs/cache.c
> @@ -55,7 +55,7 @@ static int check_cache_range(unsigned long start,
> unsigned long stop) ok = 0;
> 
>  	if (!ok)
> -		printf("CACHE: Misaligned operation at range [%08lx, %08lx]\n",
> +		debug("CACHE: Misaligned operation at range [%08lx, %08lx]\n",
>  			start, stop);
> 
>  	return ok;

Best regards,
Marek Vasut


More information about the U-Boot mailing list