[U-Boot] [PATCH] cm-t35: add I2C multi-bus support
Igor Grinberg
grinberg at compulab.co.il
Tue Apr 3 08:09:01 CEST 2012
Hi Tom,
On 04/02/12 17:18, Tom Rini wrote:
> On 04/02/2012 05:29 AM, Igor Grinberg wrote:
>> From: Nikita Kiryanov<nikita at compulab.co.il>
>>
>> Enable I2C multi-bus support and config I2C muxes for I2C2 and I2C3.
>>
>> Signed-off-by: Nikita Kiryanov<nikita at compulab.co.il>
>> Signed-off-by: Igor Grinberg<grinberg at compulab.co.il>
>
> Have you confirmed this is sufficient and there's no changes required in omap24xx_i2c.c ? Thanks!
I don't know what do you mean by sufficient...
I've tested this patch on bus 0 and 2 by reading/writing to eeproms and
it is working fine, so IMO it is sufficient.
Some time ago, I've seen a problem with Ethernet initialization
and tracked it down to:
0607e2b ARMV7: OMAP: Write more than 1 byte at a time in i2c_write
cm-t35 and cm-t3730 have Ethernet reset signal wired to TPS65930 GPIO,
so I2C transaction is needed to reset the Ethernet.
So my conclusion was that the commit above changed the timings and
that broke the Ethernet reset code.
After examining the Ethernet reset code, the fix was obvious,
as the reset code had wrong timing for the reset pulse.
So I've fixed this locally, but forgot to send a patch.
Sending in a moment...
--
Regards,
Igor.
More information about the U-Boot
mailing list