[U-Boot] [PATCH] i.MX28: Enable SD DMA only if DCache enabled

Marek Vasut marex at denx.de
Thu Apr 5 12:08:27 CEST 2012


Dear Fabio Estevam,

> On Wed, Apr 4, 2012 at 9:48 PM, Marek Vasut <marex at denx.de> wrote:
> >> Someone may want to enable cache, but still uses MMC driver in PIO mode.
> > 
> > You don't, it's slow as crap then.
> 
> Well, this is how we have been using the MMC driver for the last 4 months.

With DCache disabled though ;-)

> I like the fact that your patch let PIO and DMA mode co-exist in the
> driver and that they are selectable by the CONFIG_MXS_MMC_DMA option.
> 
> What I really don´t like is that by enabling CONFIG_SYS_DCACHE_OFF you
> force CONFIG_MXS_MMC_DMA.

All right, agreed.

> These are separate things and one config option should not force the other.

Best regards,
Marek Vasut


More information about the U-Boot mailing list