[U-Boot] [PATCH 1/7] EXYNOS: definitions of system resgister and power management registers.

[Minkyu Kang]

On 5 April 2012 15:29, Donghwa Lee <dh09.lee at samsung.com> wrote:
> This is definitions of system registers and power mananagement registers for EXYNOS SoC.
>
> Signed-off-by: Donghwa Lee <dh09.lee at samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
> Signed-off-by: Inki Dae <inki.dae at samsung.com>
> ---
>  arch/arm/cpu/armv7/exynos/Makefile        |    2 +-
>  arch/arm/cpu/armv7/exynos/power.c         |   54 +++++++++++++++++++++++++++++
>  arch/arm/cpu/armv7/exynos/system.c        |   48 +++++++++++++++++++++++++
>  arch/arm/include/asm/arch-exynos/cpu.h    |    5 +++
>  arch/arm/include/asm/arch-exynos/power.h  |    6 +++
>  arch/arm/include/asm/arch-exynos/system.h |   53 ++++++++++++++++++++++++++++
>  6 files changed, 167 insertions(+), 1 deletions(-)
>  create mode 100644 arch/arm/cpu/armv7/exynos/power.c
>  create mode 100644 arch/arm/cpu/armv7/exynos/system.c
>  create mode 100644 arch/arm/include/asm/arch-exynos/system.h
>
> diff --git a/arch/arm/cpu/armv7/exynos/power.c b/arch/arm/cpu/armv7/exynos/power.c
> new file mode 100644
> index 0000000..af7aecf
> --- /dev/null
> +++ b/arch/arm/cpu/armv7/exynos/power.c
> @@ -0,0 +1,54 @@
> +/*
> + * Copyright (C) 2012 Samsung Electronics
> + * Donghwa Lee <dh09.lee at samsung.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <common.h>
> +#include <asm/io.h>
> +#include <asm/arch/power.h>
> +
> +static void exynos4_mipi_phy_control(unsigned int enable,
> +                                       unsigned int dev_index)

Please reorder parameters, dev_index should be first parameter.

> +{
> +       struct exynos4_power *pmu =
> +           (struct exynos4_power *)samsung_get_base_power();
> +       unsigned int addr, cfg = 0;
> +
> +       if (dev_index < 1)

I think dev_index == 0 is better.

> +               addr = (unsigned int)&pmu->mipi_phy0_control;
> +       else
> +               addr = (unsigned int)&pmu->mipi_phy1_control;
> +
> +
> +       cfg = readl(addr);
> +       if (enable)
> +               cfg |= (EXYNOS_MIPI_PHY_MRESETN | EXYNOS_MIPI_PHY_ENABLE);
> +       else
> +               cfg &= ~(EXYNOS_MIPI_PHY_MRESETN | EXYNOS_MIPI_PHY_ENABLE);
> +
> +       writel(cfg, addr);
> +}
> +
> +void set_mipi_phy_ctrl(unsigned int enable, unsigned int dev_index)
> +{
> +       if (cpu_is_exynos4())
> +               exynos4_mipi_phy_control(enable, dev_index);
> +}

Thanks.
Minkyu Kang.
-- 
from. prom.
www.promsoft.net