[U-Boot] [PATCH v2 4/4] imx: Return gpio_set_value in gpio_direction_output

Stefano Babic sbabic at denx.de
Tue Apr 10 16:44:31 CEST 2012


On 10/04/2012 16:26, Vikram Narayanan wrote:
> Return gpio_set_value in gpio_direction_output.
> Earlier it returned 0 and ignored gpio_set_value's return value.
> 
> Signed-off-by: Vikram Narayanan <vikram186 at gmail.com>
> ---
>  drivers/gpio/mxc_gpio.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/mxc_gpio.c b/drivers/gpio/mxc_gpio.c
> index 21b1cdc..f1b1c16 100644
> --- a/drivers/gpio/mxc_gpio.c
> +++ b/drivers/gpio/mxc_gpio.c
> @@ -145,6 +145,5 @@ int gpio_direction_output(unsigned gpio, int value)
>  	if (ret < 0)
>  		return ret;
>  
> -	gpio_set_value(gpio, value);
> -	return 0;
> +	return gpio_set_value(gpio, value);
>  }

Acked-by: Stefano Babic <sbabic at denx.de>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list