[U-Boot] [PATCH 1/2 V3] DMA: Split the APBH DMA init into block and channel init

Stefano Babic sbabic at denx.de
Wed Apr 11 16:14:49 CEST 2012


On 09/04/2012 05:34, Marek Vasut wrote:
> This fixes the issue where mxs_dma_init() was called either twice or never,
> without introducing any new init hooks.
> 
> The idea is to allow each and every device using the APBH DMA block to
> configure and request only the channels it uses, instead of making it call init
> for all the channels as is now.
> 
> The common DMA block init part, which only configures the block, is then called
> from CPUs arch_cpu_init() call.
> 
> NOTE: This patch depends on:
> 
> 	http://patchwork.ozlabs.org/patch/150957/
> 
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Stefano Babic <sbabic at denx.de>
> Cc: Wolfgang Denk <wd at denx.de>
> Cc: Detlev Zundel <dzu at denx.de>
> Cc: Fabio Estevam <fabio.estevam at freescale.com>
> ---

After fixing the following checkpatch errors:

ERROR: open brace '{' following function declarations go on the next line
#120: FILE: drivers/dma/apbh_dma.c:579:
+int mxs_dma_init_channel(int channel) {

ERROR: that open brace { should be on the previous line
#195: FILE: drivers/mtd/nand/mxs_nand.c:1076:
+	for (j = MXS_DMA_CHANNEL_AHB_APBH_GPMI0;
+		j <= MXS_DMA_CHANNEL_AHB_APBH_GPMI7; j++)
+	{

total: 2 errors, 0 warnings, 137 lines checked

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list