[U-Boot] [PATCH] usb:udc:samsung Add functions for storing private gadget data in UDC driver
Marek Vasut
marex at denx.de
Mon Apr 16 11:41:28 CEST 2012
Dear Lukasz Majewski,
> Hi Marek Vasut,
>
> > Dear Lukasz Majewski,
> >
> > > This commit adds support for storing private data to Samsung's UDC
> > > driver. This data is afterward used by usb gadget.
> > >
> > > Signed-off-by: Lukasz Majewski <l.majewski at samsung.com>
> > > Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
> > > Cc: Marek Vasut <marex at denx.de>
> > > ---
> > >
> > > drivers/usb/gadget/s3c_udc_otg.c | 12 ++++++++++++
> > > 1 files changed, 12 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/drivers/usb/gadget/s3c_udc_otg.c
> > > b/drivers/usb/gadget/s3c_udc_otg.c index f7f7b54..cb4916c 100644
> > > --- a/drivers/usb/gadget/s3c_udc_otg.c
> > > +++ b/drivers/usb/gadget/s3c_udc_otg.c
> > > @@ -133,6 +133,18 @@ static void nuke(struct s3c_ep *ep, int
> > > status); static int s3c_udc_set_halt(struct usb_ep *_ep, int value);
> > >
> > > static void s3c_udc_set_nak(struct s3c_ep *ep);
> > >
> > > +void set_udc_gadget_private_data(void *p)
> > > +{
> > > + printf("%s: the_controller: 0x%p, p: 0x%p\n", __func__,
> > > + the_controller, p);
> > > + the_controller->gadget.dev.device_data = p;
> > > +}
> > > +
> > > +void *get_udc_gadget_private_data(struct usb_gadget *gadget)
> > > +{
> > > + return gadget->dev.device_data;
> > > +}
> > > +
> >
> > Is this part of some bigger patchset or are you simply adding dead
> > code?
>
> Yes, this is the part of a bigger patchset :-) - the composite gadget
> (g_dnl) requires this change.
>
> e.g.
>
> http://patchwork.ozlabs.org/patch/151989/
Can you please make it into a patchset then? You know -- so we all know what
this is part of.
>
> > > static struct usb_ep_ops s3c_ep_ops = {
> > >
> > > .enable = s3c_ep_enable,
> > > .disable = s3c_ep_disable,
> >
> > Best regards,
> > Marek Vasut
Best regards,
Marek Vasut
More information about the U-Boot
mailing list