[U-Boot] [PATCH 6/9] imx: usb: There is no such register

[Stefano Babic]

On 18/04/2012 09:57, Timo Ketola wrote:
> The reference manual of i.MX25 (nor i.MX31) does not define such register.
> This seems to access read only UH2_CAPLENGTH register (if
> CONFIG_MXC_USB_PORT is zero).
> 
> Signed-off-by: Timo Ketola <timo at exertus.fi>

Hi Timo,

> ---
>  drivers/usb/host/ehci-mxc.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
> index 65f40a4..6f4df58 100644
> --- a/drivers/usb/host/ehci-mxc.c
> +++ b/drivers/usb/host/ehci-mxc.c
> @@ -126,8 +126,6 @@ int ehci_hcd_init(void)
>  			HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
>  	setbits_le32(&ehci->usbmode, CM_HOST);
>  #if defined(CONFIG_MX31) || defined(CONFIG_MX25)

As far as I can see, only MX31 and MX25 boards are using this file.
Other i.MX have its own initialization file. So #if defined(CONFIG_MX31)
|| defined(CONFIG_MX25) is always true.

However, where is this code ? In current u-boot I see only #if
defined(CONFIG_MX31) at this line. Is it your patch correct ?

> -	setbits_le32(&ehci->control, USB_EN);
> -

As far as I can see, it tries to overwrite a capability register, that
is for our luck read-only. Good catch !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================