[U-Boot] [PATCH] powerpc/usb: fix bug of CPU halt when missing USB PHY clock

[Marek Vasut]

Dear Liu Shengzhou-B36685,

> Hello guys,
> 
> I didn't get an explicit list from silicon team to point out which
> platforms contain this PHY_CLK_VALID bit or not, Someone said all
> platforms have this bit, it's not true, at least we found P4080 and P1022
> no this bit. I'll trace it later.
> 
> This patch is not necessary for boards with USB PHY clock valid, just for
> those case of USB PHY clock invalid.

Roger that, thanks a lot :)

> 
> Thanks,
> Shengzhou
> 
> > -----Original Message-----
> > From: Marek Vasut [mailto:marex at denx.de]
> > Sent: Thursday, April 19, 2012 6:57 AM
> > To: Andy Fleming
> > Cc: Liu Shengzhou-B36685; u-boot at lists.denx.de
> > Subject: Re: [U-Boot] [PATCH] powerpc/usb: fix bug of CPU halt when
> > missing USB PHY clock
> > 
> > Dear Andy Fleming,
> > 
> > > Pinging you on this, again. Also, I've now moved the patch to Marek's
> > > queue, instead of mine.
> > 
> > Thanks! Did the FSL silicon team respond already?
> > 
> > > On Sun, Feb 26, 2012 at 8:44 PM, Liu Shengzhou-B36685
> > > 
> > > <B36685 at freescale.com> wrote:
> > > >> -----Original Message-----
> > > >> From: Marek Vasut [mailto:marex at denx.de]
> > > >> Sent: Monday, February 27, 2012 7:13 AM
> > > >> To: u-boot at lists.denx.de
> > > >> Cc: Liu Shengzhou-B36685
> > > >> Subject: Re: [U-Boot] [PATCH] powerpc/usb: fix bug of CPU halt when
> > > >> missing USB PHY clock
> > > >> 
> > > >> > when missing USB PHY clock and issuing "usb start" at u-boot
> > > >> > prompt, writing to or_portsc register will cause CPU halt. We
> > > >> > should check USBGP[PHY_CLK_VALID] bit at the first time in
> > > >> > ehci_hcd_init() to
> > > >> 
> > > >> avoid
> > > >> 
> > > >> > CPU hang in this case.
> > > >> > 
> > > >> > Signed-off-by: Shengzhou Liu <Shengzhou.Liu at freescale.com>
> > > >> > ---
> > > >> > 
> > > >> >  drivers/usb/host/ehci-fsl.c |   22 +++++++++++++++++++---
> > > >> >  1 files changed, 19 insertions(+), 3 deletions(-)
> > > >> 
> > > >> Hi,
> > > >> 
> > > >> what's the status of this patch/patchset?
> > > >> 
> > > >> Thanks
> > > >> M
> > > > 
> > > > Currently we found that usb CTRL_PHY_CLK_VALID bit breaks on P1022
> > > > platform, which not contains this bit. - P1023/P3041/P5020 etc, have
> > > > this bit
> > > > 
> > > >  - P3060/4080/PSC913x do have this bit, but not mentioned in RM.
> > > >  - P1022(perhaps and other) has no this bit I'm waiting for the
> > > > 
> > > > response from FSL silicon team to confirm whether there is other
> > > > platform not including this bit or not, so this patch maybe have to
> > > > be pending until I get confirmation.
> > > > 
> > > > Thanks,
> > > > Shengzhou
> > > > 
> > > > 
> > > > _______________________________________________
> > > > U-Boot mailing list
> > > > U-Boot at lists.denx.de
> > > > http://lists.denx.de/mailman/listinfo/u-boot
> > 
> > Best regards,
> > Marek Vasut

Best regards,
Marek Vasut