[U-Boot] [PATCH] fdt: avoid bad MAKEALL status

[Simon Glass]

Hi Wolfgang,

On Thu, Apr 19, 2012 at 5:36 AM, Wolfgang Denk <wd at denx.de> wrote:
> Current versions of  dtc  always print a message like
>
>        DTC: dts->dtb  on file "dt.dtb.tmp"
>
> which cannot even be suppressed with "-qqq".  To avoid incorrect
> MAKEALL status, we manually filter out this message.  This is a bit
> complicated, as we have to make sure to set a correct return code.

See the discussion on this patch:

http://patchwork.ozlabs.org/patch/149833/

A patch to fix this has now been accepted to dtc. So if you update dtc
you should find this message goes away.

3cbf829 dtc: Remove spurious output on stderr


>
> Also, get rid of the temp file: dtc accepts "-" for stdin.
>
> Signed-off-by: Wolfgang Denk <wd at denx.de>
> Cc: Simon Glass <sjg at chromium.org>
> ---
>  dts/Makefile |   10 +++++++---
>  1 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/dts/Makefile b/dts/Makefile
> index 8b13b23..914e479 100644
> --- a/dts/Makefile
> +++ b/dts/Makefile
> @@ -46,9 +46,13 @@ all: $(obj).depend $(LIB)
>  DT_BIN := $(obj)dt.dtb
>
>  $(DT_BIN): $(TOPDIR)/board/$(VENDOR)/dts/$(DEVICE_TREE).dts
> -       cat $< | $(CPP) -P $(DTS_CPPFLAGS) - >$@.tmp
> -       $(DTC) -R 4 -p 0x1000 -O dtb -o ${DT_BIN} $@.tmp
> -       rm $@.tmp
> +       rc=$$( \
> +               cat $< | $(CPP) -P $(DTS_CPPFLAGS) - | \
> +               { { $(DTC) -R 4 -p 0x1000 -O dtb -o ${DT_BIN} - 2>&1 ; \
> +                   echo $$? >&3 ; } | \
> +                 grep -v '^DTC: dts->dtb  on file' ; \
> +               } 3>&1 ) ; \
> +       exit $$rc
>
>  process_lds = \
>        $(1) | sed -r -n 's/^OUTPUT_$(2)[ ("]*([^")]*).*/\1/p'
> --
> 1.7.7.6
>

Regards,
Simon