[U-Boot] [PATCH] tegra2: move tegra2 SoC code to arch/arm/cpu/tegra2-common

Simon Glass sjg at chromium.org
Thu Apr 19 20:27:05 CEST 2012


+Albert

Hi Allen,

On Wed, Apr 18, 2012 at 3:46 PM, Allen Martin <amartin at nvidia.com> wrote:
> In preparation for splitting out the armv4t code from tegra2, move the
> tegra2 SoC code to arch/arm/cpu/tegra2-common.  This code will be
> compiled armv4t for the arm7tdmi and armv7 for the cortex A9.
>
> Signed-off-by: Allen Martin <amartin at nvidia.com>
> ---
> Resending this with "git format-patch -M" to make it more readable
> and removing cover letter
>
> This is part of an upcoming patch set to move all armv4t code out of
> tegra2 u-boot and put it into an SPL, but I wanted to get some early
> feedback on this patch.  This moves most of the tegra2 SoC code from
> arch/arm/cpu/armv7 to a new directory arch/arm/cpu/tegra2-common.
> This code will be shared between the armv7 and armv4t builds of
> tegra2.

I am not sure whether moving things up a level is OK. It makes some
sense to me but is different from what other boards do.

Secondly, you will at some point add Tegra 3 support I suppose. In
that case much of this code will become common anyway. Should you do
that split (tegra-common, tegra2-common) now or later?

Regards,
Simon


More information about the U-Boot mailing list