[U-Boot] [PATCH] ehci-omap: fix for enabling the correct usb port

[Govindraj]

On Fri, Apr 20, 2012 at 2:55 AM, Jeroen Hofstee <jeroen at myspectrum.nl> wrote:
> This is just a patch for the problem reported here:
> http://lists.denx.de/pipermail/u-boot/2012-February/117580.html originally reported by Igor.
>
> "Looks like this is copy paste error from my side,(for port2/3 it should have been bypass
>  for port2/3 rather its port1 set in bypass mode)"
>
> I only submit the patch since it is missing in 2012.04-rc3 while the twister board
> depends on it. Maybe it is already somewhere in the reposistory, but I cannot find it.
>
> note: the twister boards still needs an additional `usb reset`, don't know why.
>
> U-Boot 2012.04-rc3-dirty (Apr 19 2012 - 21:38:38)
>
> AM35XX-GP ES1.0, CPU-OPP2, L3-165MHz, Max CPU Clock 600 Mhz
> TAM3517 TWISTER Board + LPDDR/NAND
> I2C:   ready
> DRAM:  256 MiB
> NAND:  512 MiB
> MMC:   OMAP SD/MMC: 0
> In:    serial
> Out:   serial
> Err:   serial
> Die ID #746c0000000000000155dc1405011024
> Net:   DaVinci-EMAC, smc911x-0
> Hit any key to stop autoboot:  0
> twister => usb start
> (Re)start USB...
> USB:   Register 1313 NbrPorts 3
> USB EHCI 1.00
> scanning bus for devices... 1 USB Device(s) found
>       scanning bus for storage devices... 0 Storage Device(s) found
> twister => usb reset
> (Re)start USB...
> USB:   Register 1313 NbrPorts 3
> USB EHCI 1.00
> scanning bus for devices... 1 USB Device(s) found
>       scanning bus for storage devices... 0 Storage Device(s) found
> twister => usb reset
> (Re)start USB...
> USB:   Register 1313 NbrPorts 3
> USB EHCI 1.00
> scanning bus for devices... 1 USB Device(s) found
>       scanning bus for storage devices... 0 Storage Device(s) found
> twister => usb reset
> (Re)start USB...
> USB:   Register 1313 NbrPorts 3
> USB EHCI 1.00
> scanning bus for devices... 1 USB Device(s) found
>       scanning bus for storage devices... 0 Storage Device(s) found
>

Yes it was a typo and Looks like the corrected patch was not picked up
as in here:
http://permalink.gmane.org/gmane.comp.boot-loaders.u-boot/124620

FWIW

Acked-by: Govindraj.R <govindraj.raja <at> ti.com>

>
> Signed-off-by: Jeroen Hofstee <jeroen at myspectrum.nl>
> ---
>  drivers/usb/host/ehci-omap.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
> index 00f787f..1ed7710 100644
> --- a/drivers/usb/host/ehci-omap.c
> +++ b/drivers/usb/host/ehci-omap.c
> @@ -200,12 +200,12 @@ int omap_ehci_hcd_init(struct omap_usbhs_board_data *usbhs_pdata)
>                if (is_ehci_phy_mode(usbhs_pdata->port_mode[1]))
>                        clrbits_le32(&reg, OMAP_UHH_HOSTCONFIG_ULPI_P2_BYPASS);
>                else
> -                       setbits_le32(&reg, OMAP_UHH_HOSTCONFIG_ULPI_P1_BYPASS);
> +                       setbits_le32(&reg, OMAP_UHH_HOSTCONFIG_ULPI_P2_BYPASS);
>
>                if (is_ehci_phy_mode(usbhs_pdata->port_mode[2]))
>                        clrbits_le32(&reg, OMAP_UHH_HOSTCONFIG_ULPI_P3_BYPASS);
>                else
> -                       setbits_le32(&reg, OMAP_UHH_HOSTCONFIG_ULPI_P1_BYPASS);
> +                       setbits_le32(&reg, OMAP_UHH_HOSTCONFIG_ULPI_P3_BYPASS);
>        } else if (rev == OMAP_USBHS_REV2) {
>                clrsetbits_le32(&reg, (OMAP_P1_MODE_CLEAR | OMAP_P2_MODE_CLEAR),
>                                        OMAP4_UHH_HOSTCONFIG_APP_START_CLK);
> --
> 1.7.5.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot