[U-Boot] [PATCH v2 01/21] net: Remove CMD_PING where there's no CMD_NET

[Simon Glass]

Hi Joe,

On Tue, Mar 27, 2012 at 4:42 PM, Joe Hershberger <joe.hershberger at ni.com> wrote:
> Some boards claim to need ping, but don't support net.
> That makes no sense, and causes problems now that ping
> is in a separate file.
>
> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Joe Hershberger <joe.hershberger at gmail.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Mike Frysinger <vapier at gentoo.org>

Acked-by: Simon Glass <sjg at chromium.org>

See question below too.

> ---
> Changes for v2:
>   - Separated from "Move PING out of net.c"
>
>  include/configs/am3517_crane.h |    2 +-
>  include/configs/am3517_evm.h   |    2 +-
>  include/configs/origen.h       |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/configs/am3517_crane.h b/include/configs/am3517_crane.h
> index b0dd2f0..848e4ae 100644
> --- a/include/configs/am3517_crane.h
> +++ b/include/configs/am3517_crane.h
> @@ -146,7 +146,7 @@
>  #define CONFIG_CMD_MMC         /* MMC support                  */
>  #define CONFIG_CMD_NAND                /* NAND support                 */
>  #define CONFIG_CMD_DHCP

Should you remove the DHCP also?

> -#define CONFIG_CMD_PING
> +#undef CONFIG_CMD_PING
>
>  #undef CONFIG_CMD_FLASH                /* flinfo, erase, protect       */
>  #undef CONFIG_CMD_FPGA         /* FPGA configuration Support   */
> diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h
> index b5f75d1..3b4cb07 100644
> --- a/include/configs/am3517_evm.h
> +++ b/include/configs/am3517_evm.h
> @@ -145,7 +145,7 @@
>  #define CONFIG_CMD_MMC         /* MMC support                  */
>  #define CONFIG_CMD_NAND                /* NAND support                 */
>  #define CONFIG_CMD_DHCP
> -#define CONFIG_CMD_PING
> +#undef CONFIG_CMD_PING
>
>  #undef CONFIG_CMD_FLASH                /* flinfo, erase, protect       */
>  #undef CONFIG_CMD_FPGA         /* FPGA configuration Support   */
> diff --git a/include/configs/origen.h b/include/configs/origen.h
> index 8ede825..985b16d 100644
> --- a/include/configs/origen.h
> +++ b/include/configs/origen.h
> @@ -82,7 +82,7 @@
>  /* Command definition*/
>  #include <config_cmd_default.h>
>
> -#define CONFIG_CMD_PING
> +#undef CONFIG_CMD_PING
>  #define CONFIG_CMD_ELF
>  #define CONFIG_CMD_DHCP
>  #define CONFIG_CMD_MMC
> --
> 1.6.0.2
>

Regards,
Simon