[U-Boot] [RESEND 2/2] mmc:fix Call mmc_init() when executing mmc_get_dev()

Lei Wen adrian.wenl at gmail.com
Sat Apr 21 10:39:29 CEST 2012


Hi Lukasz,

On Fri, Apr 20, 2012 at 3:09 PM, Lukasz Majewski <l.majewski at samsung.com> wrote:
> Hi, Lei
>
>> I'm concerning with this adding init here.
>> Since not every platform mount with emmc as boot device, and what they
>> need is booting fast.
>
> If I remember correctly, u-boot policy is to not initialize the mmc
> until it is needed (i.e. command is executed).
> So the extra init won't be executed until fatls or mmc is executed.
>
>> If you order them to initialize all mmc/sd at
>> mmc register stage, this adding booting time may not be the one they
>> want to see.
>
> I think that booting time will not increase, because in the mmc_init()
> there is a check:
>
>        if (mmc->has_init)
>                return 0;
>
> To prevent multiple register level initialization.
>
> The execution time increase is boiled down to executing a
> few instructions (when mmc->has_init is set).
>
>
I misunderstood your original patch...
I was thinking you want to init the mmc device directly in the mmc register
process which is a bad idea. But since you add the init only in the get_dev,
I think this approach is ok to me.

Thanks,
Lei


More information about the U-Boot mailing list