[U-Boot] [PATCH] i.MX6: Add ANATOP regulator init

[Stefano Babic]

On 13/04/2012 10:00, Dirk Behme wrote:
> Init the core regulator voltage to 1.2V. This is required for the correct
> functioning of the GPU and when the ARM LDO is set to 1.225V. This is a
> workaround to fix some memory clock jitter.
> 
> Note: This should be but can't be done in the DCD. The bootloader
>       prevents access to the ANATOP registers.
> 
> Signed-off-by: Dirk Behme <dirk.behme at de.bosch.com>
> CC: Jason Chen <b02280 at freescale.com>
> CC: Jason Liu <r64343 at freescale.com>
> CC: Ranjani Vaidyanathan <ra5478 at freescale.com>
> CC: Stefano Babic <sbabic at denx.de>
> CC: Fabio Estevam <festevam at gmail.com>
> ---

Hi Dirk,

> +static void init_anatop_reg(void)
> +{
> +	struct anatop_regs *anatop = (struct anatop_regs *)ANATOP_BASE_ADDR;
> +	int reg = readl(&anatop->reg_core);
> +
> +	/*
> +	 * Increase the VDDSOC to 1.2V
> +	 * Mask out the REG_CORE[22:18] bits (REG2_TRIG)
> +	 * and set them to 1.2V (0.7V + 0x14 * 0.025V)
> +	 */
> +	reg = (reg & ~(0x1F << 18)) | (0x14 << 18);

Everything clear, but what do you mind to add an accessor to set this
voltage ? It is straightforward, and more boards could use it.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================