[U-Boot] [RFC] Preventing overriding of serverip when set in environment by user

[Maupin, Chase]

> -----Original Message-----
> From: Stefano Babic [mailto:sbabic at denx.de]
> Sent: Thursday, April 19, 2012 4:14 AM
> To: Peter Barada
> Cc: u-boot at lists.denx.de; Maupin, Chase
> Subject: Re: [U-Boot] [RFC] Preventing overriding of serverip
> when set in environment by user
> 
> On 18/04/2012 17:46, Peter Barada wrote:
> > On 04/18/2012 11:28 AM, Wolfgang Denk wrote:
> >>
> >>> Is this the proper way to fix this issue and the right
> location to
> >>> make the change? The overall goal was to make sure that if I
> >>> specified a particular serverip that I wanted to use, then
> the DHCP
> >>> server should not be changing that.
> >> No, this is not an acceptable patch.
> >>
> >> What exactly _are_ you trying to fix?  What is wrong with
> using the
> >> DHCP server supplied address?  If it is incorrect, you should
> fix your
> >> DHCP server configuration.
> > I have the same type of problem.
> >
> > In my case our company controls the DHCP server that hands out
> addresses
> > for the network, but I want to use a *local* TFTP server (the
> one on my
> > development machine).  I can't modify the DHCP server so if I
> use "dhcp"
> > to get and address u-boot also overwrites serverip.  At home my
> FiOS
> > router has a DHCP server (that I can't modify since its closed
> and is
> > needed to provide addresses to my TV set top box) that provides
> > addresses for my network, and has the same problem...
> >
> > Would an option to dhcp (i.e. one that tells it to *only*
> modify ipaddr)
> > suffice? Or would it be better to provide an entirely a new
> command that
> > optionally updates the variables in the environment be better?
> Then
> > users have the option of using "dhcp" as is, or for
> environments like
> > mine (and apparently Chase) can just get an IP address and go
> from there...
> 
> There is already such as option. You can pass the tftp server in
> the
> "tftp"command, see code:
> 
> 	tftp [loadAddress] [[hostIPaddr:]bootfilename]
> 
> for example, something like
> 	tftp 0x80008000 192.168.1.1:uImage
> 
> Is it not enough ?

I think it will be.  This can be worked around and I had a misunderstanding of how the DHCP response was being used.  Thanks.

> 
> Best regards,
> Stefano Babic
> 
> --
> =================================================================
> ====
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev
> Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> Germany
> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email:
> sbabic at denx.de
> =================================================================
> ====