[U-Boot] [PATCH v2 2/3] LCD: add compressed 32bpp BMP image data
Wolfgang Denk
wd at denx.de
Thu Apr 26 14:43:45 CEST 2012
Dear Donghwa Lee,
In message <4F99057F.5040907 at samsung.com> you wrote:
> This patch is 32bpp BMP image data that is converted to header
> after gzip. I had agonized about where these data located.
> I think TIZEN is not specific on board and SoC, so I determined
> that position is proper in include/.
> If you have other opinions, please comment to me.
>
> Signed-off-by: Donghwa Lee <dh09.lee at samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
> ---
> include/tizen_logo.h | 5071 +++++++++++++++++++++++++++++++++++++++++++++
> include/tizen_logo_data.h | 30 +
> 2 files changed, 5101 insertions(+), 0 deletions(-)
> create mode 100644 include/tizen_logo.h
> create mode 100644 include/tizen_logo_data.h
Please make sure to include a changelog; this is a mandatory
requirement, see
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
I reject your patch. I will not accept to have such board and/or
vendor specific data in the top level include/ directory. Please move
this to the respective board or vendor directory, as I have asked you
do to before.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every program has at least one bug and can be shortened by at least
one instruction -- from which, by induction, one can deduce that
every program can be reduced to one instruction which doesn't work.
More information about the U-Boot
mailing list