[U-Boot] [PATCH 2/4] patman: Add meaningful statements instead of blah blah
Simon Glass
sjg at chromium.org
Thu Apr 26 20:01:57 CEST 2012
Hi Vikram,
On Thu, Apr 26, 2012 at 3:45 AM, Vikram Narayanan <vikram186 at gmail.com>wrote:
> Signed-off-by: Vikram Narayanan <vikram186 at gmail.com>
> Cc: Simon Glass <sjg at chromium.org>
>
It would be better if you added a commit message for each of these patches,
even a brief one. Otherwise:
Acked-by: Simon Glass <sjg at chromium.org>
> ---
> tools/patman/README | 9 ++++-----
> 1 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/tools/patman/README b/tools/patman/README
> index d9820ab..d98f081 100644
> --- a/tools/patman/README
> +++ b/tools/patman/README
> @@ -132,16 +132,15 @@ Series-prefix: prefix
>
> Cover-letter:
> This is the patch set title
> -blah blah
> -more blah blah
> +This patch set fixes the errors when CONFIG_xxx is enabled.
> +Tested on xyz board.
> END
> Sets the cover letter contents for the series. The first line
> will become the subject of the cover letter
>
> Series-notes:
> -blah blah
> -blah blah
> -more blah blah
> +Sorry that I couldn't find time to reply for the comments posted on the
> v1 of my
> +patch. This patch superseeds v1. Please comment.
> END
> Sets some notes for the patch series, which you don't want in
> the commit messages, but do want to send, The notes are joined
> --
> 1.7.4.1
>
>
More information about the U-Boot
mailing list